Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: make release work #15850

Merged
merged 13 commits into from Oct 26, 2023
Merged

raftstore: make release work #15850

merged 13 commits into from Oct 26, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Oct 26, 2023 •
edited

What is changed and how it works?

Issue Number: Close #15851

What's Changed:

Related changes

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

Release note 

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@bufferflies bufferflies marked this pull request as ready for review October 26, 2023 09:36
@ti-chi-bot ti-chi-bot bot added status/LGT1 Status: PR - There is already 1 approval do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Oct 26, 2023
pingyu
pingyu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Oct 26, 2023
@bufferflies
Copy link
Contributor Author

/check-issue-triage-complete

@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b94ea1c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Oct 26, 2023
@bufferflies
Copy link
Contributor Author

/run-test retry=5

@ti-chi-bot ti-chi-bot bot merged commit 763069e into tikv:master Oct 26, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Oct 26, 2023
@glorv
Copy link
Contributor

glorv commented Nov 6, 2023

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15923.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 6, 2023
@bufferflies @ti-chi-bot
raftstore: make release work (tikv#15850)
f616436 
close tikv#15851

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 6, 2023
Merged
bufferflies added a commit to ti-chi-bot/tikv that referenced this pull request Nov 6, 2023
@bufferflies
raftstore: make release work (tikv#15850)
66314c1 
close tikv#15851

Signed-off-by: bufferflies <1045931706@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2023
@ti-chi-bot @bufferflies
raftstore: make release work (#15850) (#15923)
32d043f 
close #15851

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: tongjian <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.5 release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

release failed
4 participants
@bufferflies @glorv @ti-chi-bot @pingyu