Revert "*: make unified-pool use FuturePool (#15925)" #16050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/hold |
|
/release |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nolouch
force-pushed
the
revert
branch
3 times, most recently
from
55fa2a5
to
a614eb6
Compare
|
/unhold |
This reverts commit 7be1b17. Signed-off-by: nolouch <nolouch@gmail.com>
|
Benchmark with sysbench TiKV: 3* 16c 48GB Memory Command: Basehash result: Bad PR :hash: This PR:result |
|
PTAL @glorv @bufferflies |
bufferflies
reviewed
Dec 21, 2023
| @@ -754,6 +791,12 @@ mod metrics { | |||
| &["name"] | |||
| ) | |||
| .unwrap(); | |||
| pub static ref UNIFIED_READ_POOL_RUNNING_THREADS: IntGaugeVec = register_int_gauge_vec!( | |||
| "tikv_unified_read_pool_thread_count", | |||
| "The number of running threads in the unified read pool", | |||
There was a problem hiding this comment.
Suggested change
| "The number of running threads in the unified read pool", | |
| "The number of running tasks in the unified read pool", |
maybe pending task is more readable.
There was a problem hiding this comment.
Its threads in here.
bufferflies
approved these changes
Dec 21, 2023
glorv
approved these changes
Dec 21, 2023
|
/merge |
|
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 1642e33
|
|
@nolouch: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
nolouch
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Dec 21, 2023
close tikv#16015 Revert "*: make unified-pool use FuturePool (tikv#15925)" - revert due to performance regression Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
nolouch
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Dec 21, 2023
close tikv#16015 Revert "*: make unified-pool use FuturePool (tikv#15925)" - revert due to performance regression Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7be1b17.
What is changed and how it works?
Issue Number: Close #16015
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note