Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: make initialize failure fatal error, release memory while task stopped. #16071

Merged
merged 3 commits into from
Nov 30, 2023
Merged

log-backup: make initialize failure fatal error, release memory while task stopped. #16071

merged 3 commits into from
Nov 30, 2023

Conversation

YuJuncen
Copy link
Contributor

What is changed and how it works?

Issue Number: Close #16056, close #16070

What's Changed:
This PR fixed the problems above.

Check List

Tests

  • Unit test
  • Integration test

Release note 

(applies to 7.5.x) Fixed a bug that may cause memory cannot be released after log backup task stopped.
Fixed a bug that may cause log backup started but not work properly if there are connective issue to PD during initializing the task.

@YuJuncen
WIP
9349e52 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YuJuncen
make clippy happy
d33cb90 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 29, 2023
Connor1996
Connor1996 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 30, 2023
@Connor1996
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d33cb90

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Nov 30, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit fd98944 into tikv:master Nov 30, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 30, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16108.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 30, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 30, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16071
9b34274 
close tikv#16056, close tikv#16070

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16109.

This was referenced Nov 30, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16110.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 30, 2023
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16071
c870c15 
close tikv#16056, close tikv#16070

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 8, 2023
@ti-chi-bot @YuJuncen @iosmanthus
log-backup: make initialize failure fatal error, release memory while…
8e5ea99 
… task stopped. (#16071) (#16108)

close #16056, close #16070

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: iosmanthus <dengliming@pingcap.com>
ti-chi-bot bot added a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot @YuJuncen @ti-chi-bot
log-backup: make initialize failure fatal error, release memory while…
0998d1f 
… task stopped. (#16071) (#16110)

close #16056, close #16070

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Jan 31, 2024
@ti-chi-bot @YuJuncen @ti-chi-bot
log-backup: make initialize failure fatal error, release memory while…
2dba329 
… task stopped. (#16071) (#16109)

close #16056, close #16070

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 needs-cherry-pick-release-7.5 release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
5 participants
@YuJuncen @Connor1996 @ti-chi-bot @overvenus @Leavrth