Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add extra filters to filter out redundant data. #16103

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Nov 30, 2023

What is changed and how it works?

Issue Number: Close #16102

What's Changed:

Add some necessary filters to filter out unnecessary data in metrics.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: None.
  • Need to cherry-pick to the release branch: No need

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Generate a new tikv_details.json with the auto-gen tool
    • Load it into grafana.
      image

Side effects

None

Release note

None

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@LykxSassinator LykxSassinator changed the title bugfix: add extra filters to filter out redundant data. metrics: add extra filters to filter out redundant data. Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added the size/M label Nov 30, 2023
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description's checklist

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Nov 30, 2023
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Nov 30, 2023
@overvenus
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: add573e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit bab43d0 into tikv:master Nov 30, 2023
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: some minor bugs have side effects to observability
3 participants