Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: change the log level to debug for cop error response #16116

Merged

Conversation

cfzjywxk
Copy link
Collaborator

@cfzjywxk cfzjywxk commented Dec 4, 2023

What is changed and how it works?

Issue Number: Ref #15881

What's Changed:
Pick #15882 to the standalone branch.

Change the coprocessor error response log level to DEBUG.

Related changes

Check List

Tests

None

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@cfzjywxk cfzjywxk added the type/cherry-pick Type: PR - Cherry pick label Dec 4, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

}
};
COPR_REQ_ERROR.with_label_values(&[tag]).inc();
make_error_response_common!(batch_resp, tag, e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that it can be a function after moving the declaration tag (which is not used elsewhere) into it. 🤔 LGTM since it's consistent with master branch

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 5, 2023
@cfzjywxk
Copy link
Collaborator Author

cfzjywxk commented Dec 6, 2023

/test

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 8, 2023
@cfzjywxk
Copy link
Collaborator Author

cfzjywxk commented Dec 8, 2023

/test

@cfzjywxk
Copy link
Collaborator Author

cfzjywxk commented Dec 8, 2023

Unrelated failure

[2023-12-08T05:26:37.364Z] failures:
[2023-12-08T05:26:37.364Z]     test_life::test_life_by_message

@cfzjywxk
Copy link
Collaborator Author

cfzjywxk commented Dec 8, 2023

/test

1 similar comment
@cfzjywxk
Copy link
Collaborator Author

/test

@cfzjywxk cfzjywxk merged commit 5254897 into tikv:tikv-6.5-with-kv-timeout-feature Dec 13, 2023
2 of 3 checks passed
mittalrishabh pushed a commit to mittalrishabh/tikv that referenced this pull request May 8, 2024
…kv#11)

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants