Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sst_importer: remove the SST file where no kvs written into #16146

Merged
merged 4 commits into from
Apr 30, 2024
Merged

sst_importer: remove the SST file where no kvs written into #16146

merged 4 commits into from
Apr 30, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Dec 5, 2023 •
edited

What is changed and how it works?

Issue Number: Close #16005

What's Changed:

This PR has remove the empty SST file in the db/import.

* remove the sst file where no kvs written into

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@Leavrth
remove the sst file where no kvs written into
bd838f2 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Connor1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Connor1996
Connor1996 reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also clean up the already existed empty sst files

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 11, 2023

Please also clean up the already existed empty sst files

It seems only release-6.5 would open the sst when clean ssts. I will modify in the cherry-pick PR.

@BornChanger
Copy link
Contributor

@Connor1996 please take another look

Connor1996
Connor1996 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 29, 2024
@Leavrth
add test to check the empty file is removed
0b72784 
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 0b72784

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

@Leavrth: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 72a0fd5 into tikv:master Apr 30, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16933.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Open
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16934.

This was referenced Apr 30, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #16935.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16936.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot @Leavrth
sst_importer: remove the SST file where no kvs written into (#16146) (#…
56613f7 
…16935)

close #16005

This PR has remove the empty SST file in the db/import.

* remove the sst file where no kvs written into

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>

Co-authored-by: Leavrth <jianjun.liao@outlook.com>
Co-authored-by: Jianjun Liao <jianjun.liao@outlook.com>
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2024
@ti-chi-bot @Leavrth
sst_importer: remove the SST file where no kvs written into (#16146) (#…
4602080 
…16934)

close #16005

This PR has remove the empty SST file in the db/import.

* remove the sst file where no kvs written into

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>

Co-authored-by: Leavrth <jianjun.liao@outlook.com>
Co-authored-by: Jianjun Liao <jianjun.liao@outlook.com>
Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2024
@ti-chi-bot @Leavrth
sst_importer: remove the SST file where no kvs written into (#16146) (#…
9df92e8 
…16936)

close #16005

This PR has remove the empty SST file in the db/import.

* remove the sst file where no kvs written into

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>

Co-authored-by: Leavrth <jianjun.liao@outlook.com>
Co-authored-by: Jianjun Liao <jianjun.liao@outlook.com>
Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 needs-cherry-pick-release-7.5 needs-cherry-pick-release-8.1 release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

sst_importer needs to clean the sst if no kv need to be saved and rewritten
6 participants
@Leavrth @BornChanger @YuJuncen @ti-chi-bot @3pointer @Connor1996