Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-io: upgrade to latest version - v0.13.0. #16165

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Dec 11, 2023

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Upgrade the grpc-io lib to the latest version - v0.13.0.

Meanwhile, the format of `cargo.toml` is re-arranged and become tidier than the older version.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Upgrade the grpc-io lib to the latest version - v0.13.0.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Dec 11, 2023
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to compare the performance between the current and this pr.

@ti-chi-bot ti-chi-bot bot added status/LGT1 Status: PR - There is already 1 approval needs-rebase labels Dec 12, 2023
@LykxSassinator
Copy link
Contributor Author

You need to compare the performance between the current and this pr.

Thx for reminding.
Yep, I will add and supply the performance testing results between master and this pr.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase label Dec 12, 2023
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

/test

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

/test retry=7

@LykxSassinator
Copy link
Contributor Author

/test threads=4 retry=7

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Dec 22, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Dec 27, 2023

Maybe this pr could be paused, found two problems to this pr:

  • According to testing records, based on TPCC workloads, the newly upgraded version v0.13.0 caused the raising on CPU.usage, about ~12% to ~15% based on the results.
  • The uts still have some abnormal cases which cannot be fixed directly, throwing SIGABRT signal and aborting all consequential cases. Basically, I've tried to replace the unsafe tokio::runtime with the safe RuntimeWrapper, which will safely releasing the Runtime object when drop. But some uts still are hung by the abnormal signal SIGABRT.

Related issue to grpc-io can be reviewed in: tikv/grpc-rs#643

PS: By testing with tpcc-1000 warehouses (CPU: 16 cores) , the performance results can be reviewed in the following table. And the throughput didn't differ a lot, but the CPU.usage on upgrading v0.13.0 is much higher than the nightly version.

  • QPS part: (higher is better)
Concurrency upgrading v0.13.0 Master (nightly version)
50 threads 20841 21272
100 threads 21552 21640
150 threads 21378 21531
200 threads 20586 21104
  • CPU part: (higher means more cost on CPU.usage)
Concurrency upgrading v0.13.0 Master (nightly version)
50 threads 1421% 1283%
100 threads 1530% 1347%
150 threads 1610% 1422%
200 threads 1645% 1464%

Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

@LykxSassinator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 84721d2 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants