Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv_util: add handled task counter for LazyWorker #16196

Merged
merged 6 commits into from Dec 21, 2023

Conversation

overvenus
Copy link
Member

Add a metric to inspect the total number of tasks handled by a LazyWorker.

What is changed and how it works?

Issue Number: Close #16195

What's Changed:

Add a metric to inspect the total number of tasks handled by a LazyWorker.

Check List

Tests

  • Unit test

Release note

None

Add a metric to inspect the total number of tasks handled by a LazyWorker.

Signed-off-by: Neil Shen <overvenus@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 19, 2023
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 20, 2023
@overvenus
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c1cd832

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Dec 21, 2023
@overvenus
Copy link
Member Author

/hold

Signed-off-by: Neil Shen <overvenus@gmail.com>
…nto fix-lazy-worker-metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Status: Can merge to base branch label Dec 21, 2023
@overvenus
Copy link
Member Author

/unhold

@overvenus
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e7e23ee

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@overvenus: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3d8f625 into tikv:master Dec 21, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The metric handled task is missing for LazyWorker
3 participants