Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: do not suffix "fips" for tikv version ouput #16201

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Dec 19, 2023

What is changed and how it works?

Issue Number: Close #16200
See #16199

Do not suffix "fips" for tikv version ouput

What's Changed:


Check List

Tests

  • Manual test
    tikv-server -V

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 20, 2023
@glorv
Copy link
Contributor

glorv commented Dec 20, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@glorv: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6b43a44

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Dec 20, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@overvenus: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1f384cf into tikv:master Dec 20, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "fips" suffix for TiKV CARGO_PKG_VERSION
3 participants