Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric: add read scan duration panel #16205

Merged
merged 2 commits into from Dec 21, 2023

Conversation

cfzjywxk
Copy link
Collaborator

@cfzjywxk cfzjywxk commented Dec 20, 2023

What is changed and how it works?

Issue Number: ref #15066

What's Changed:
After #16180, the in-memory pessimstic locks would be scanned in the resolve lock phase.
Monitoring it is helpful for analyzing performance impact and deciding whether further optimization of scan lock is necessary, as the in-memory pessimistic lock is a critical component that impacts performance.

Add scan lock read duration panel to check read lock holding time.
image

Related changes

Check List

Tests

Side effects

Release note

None

Signed-off-by: cfzjywxk <lsswxrxr@163.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Dec 21, 2023
@cfzjywxk
Copy link
Collaborator Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@cfzjywxk: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e01bd2a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@cfzjywxk: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 01498b0 into tikv:master Dec 21, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16207.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 21, 2023
ref tikv#15066

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #16208.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 21, 2023
ref tikv#15066

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16209.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 21, 2023
ref tikv#15066

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants