Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Memory Engine: WriteBatch with Skiplist Engine #16433

Merged
merged 12 commits into from
Jan 31, 2024
Merged

In-Memory Engine: WriteBatch with Skiplist Engine #16433

merged 12 commits into from
Jan 31, 2024

Commits on Jan 30, 2024

  1. In-Memory: Write Batch Part II. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d4d3cd0 View commit details
    Browse the repository at this point in the history

  2. Cleanup. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2ee429d View commit details
    Browse the repository at this point in the history

  3. Test writing to both engines. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    acd19b8 View commit details
    Browse the repository at this point in the history

  4. HybridEngineSnapshot impl. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    946d691 View commit details
    Browse the repository at this point in the history

  5. Further cleanup, docs. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e387718 View commit details
    Browse the repository at this point in the history

  6. Remove redundant code from write_impl. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3c1975b View commit details
    Browse the repository at this point in the history

  7. Use ShardedLock for engine.core(), hold read lock when writing batche… 

    …s to avoid writing keys for evicted range.

Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    56ab380 View commit details
    Browse the repository at this point in the history

  8. Fix doctest for hybrid_engine_for_tests 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    49fb3c0 View commit details
    Browse the repository at this point in the history

  9. Smaller scope for lock. 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7e38ce2 View commit details
    Browse the repository at this point in the history

  10. Add test in raftstore/read.rs::test_hybrid_engine_read() 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    21ba4a1 View commit details
    Browse the repository at this point in the history

  11. Remove apply_cb 

    Signed-off-by: Alex Feinberg <alex@strlen.net>
    @afeinberg
    afeinberg committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a6621af View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Merge branch 'master' into afeinberg/memory_engine/hybrid_engine_writ… 

    …e_batch_p2
    @ti-chi-bot
    ti-chi-bot[bot] committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5030e00 View commit details
    Browse the repository at this point in the history