Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: improve the remove peer check (#16467) #16470

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16467

What is changed and how it works?

Issue Number: Close #16465

What's Changed:

improve the remove peer check. Only check when the updating role is voter

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

…oter

Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jan 31, 2024
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jan 31, 2024
@tonyxuqqi
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ad096d3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jan 31, 2024
@ti-chi-bot ti-chi-bot bot merged commit 13bbe32 into tikv:release-6.5 Jan 31, 2024
3 checks passed
tonyxuqqi added a commit to tonyxuqqi/tikv that referenced this pull request Feb 1, 2024
…6470)"

This reverts commit 13bbe32.

Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants