Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: polish the availability check on conf change requests #16486

Merged
merged 4 commits into from Feb 2, 2024
Merged

raftstore: polish the availability check on conf change requests #16486

merged 4 commits into from Feb 2, 2024

Conversation

tonyxuqqi
Copy link
Contributor

@tonyxuqqi tonyxuqqi commented Feb 1, 2024 •
edited

What is changed and how it works?

Issue Number: Close #16465

What's Changed:

When calculating the impact of conf change, include all operations into considerations.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@tonyxuqqi
polish the availability check on conf change requests
3870728 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • LykxSassinator

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@tonyxuqqi
include IncomingVoter
8e07748 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
LykxSassinator
LykxSassinator approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Feb 2, 2024
LykxSassinator
LykxSassinator reviewed Feb 2, 2024
View reviewed changes
components/raftstore/src/store/util.rs
}
}
}

let is_healthy = normal_voters.len() > slow_voters.len();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tip, if is_healthy already is false, the following steps for checking could be skipped.

@Connor1996 Connor1996 changed the title polish the availability check on conf change requests raftstore: polish the availability check on conf change requests Feb 2, 2024
Connor1996
Connor1996 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Feb 2, 2024
@tonyxuqqi
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 5df0f68

@ti-chi-bot ti-chi-bot bot merged commit 04370e9 into tikv:master Feb 2, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Feb 2, 2024
tonyxuqqi added a commit to ti-chi-bot/tikv that referenced this pull request Feb 2, 2024
@tonyxuqqi
raftstore: polish the availability check on conf change requests (tik…
92f72a5 
…v#16486)

close tikv#16465

When calculating the impact of conf change, include all operations into considerations.

Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@tonyxuqqi
Copy link
Contributor Author

/cherry-pick release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Feb 2, 2024
@tonyxuqqi @ti-chi-bot
This is an automated cherry-pick of tikv#16486
37a9852 
close tikv#16465

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@tonyxuqqi: new pull request created to branch release-7.5: #16489.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 2, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 6, 2024
@ti-chi-bot @tonyxuqqi
raftstore: polish the availability check on conf change requests (#16486
24fe68e 
) (#16489)

close #16465

When calculating the impact of conf change, include all operations into considerations.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
dbsid pushed a commit to dbsid/tikv that referenced this pull request Mar 24, 2024
@tonyxuqqi @dbsid
raftstore: polish the availability check on conf change requests (tik…
6632298 
…v#16486)

close tikv#16465

When calculating the impact of conf change, include all operations into considerations.

Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

(dr-autosync) v6.5.8 scale in one node from primary datacenter failed during async mode
4 participants
@tonyxuqqi @ti-chi-bot @Connor1996 @LykxSassinator