Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb_query_datatype, tidb_query_expr: Add div_precision_increment support in dag request #16622

Merged
merged 10 commits into from Mar 13, 2024
Merged

tidb_query_datatype, tidb_query_expr: Add div_precision_increment support in dag request #16622

merged 10 commits into from Mar 13, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 11, 2024 •
edited

What is changed and how it works?

Issue Number: close #16627, ref pingcap/tidb#51501

What's Changed:

Add support for div_precision_increment in dag request.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@yibin87
Add div_precision_increment support in dag request
5380fe5 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 11, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none contribution Type: PR - From contributors size/S labels Mar 11, 2024
@yibin87
Add unit test
fbffb0a 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Mar 11, 2024
@yibin87
Triage
37decb3 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Mar 11, 2024
@yibin87
Fix format
85dd683 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 11, 2024

/hold

gengliqi
gengliqi reviewed Mar 11, 2024
View reviewed changes
components/tidb_query_datatype/src/expr/ctx.rs Outdated
@@ -72,6 +74,7 @@ pub struct EvalConfig {
pub sql_mode: SqlMode,

pub paging_size: Option<u64>,
pub div_precision_increment: i32,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the type should be u8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, updated

components/tidb_query_datatype/src/expr/ctx.rs Outdated
@@ -108,6 +114,7 @@ impl EvalConfig {
max_warning_cnt: DEFAULT_MAX_WARNING_CNT,
sql_mode: SqlMode::empty(),
paging_size: None,
div_precision_increment: DEFAULT_DIV_PRECISION_INCR,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new default value, how about using the existing value DEFAULT_DIV_FRAC_INCR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, changed it.

@yibin87
Address comments
39c5dbe 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 requested a review from gengliqi March 12, 2024 02:25
gengliqi
gengliqi approved these changes Mar 12, 2024
View reviewed changes
components/tidb_query_datatype/src/codec/mysql/decimal.rs Outdated
@@ -1,5 +1,4 @@
// Copyright 2016 TiKV Project Authors. Licensed under Apache-2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should leave a blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 12, 2024
@yibin87
Address comments
22fc396 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 12, 2024
@gengliqi
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 13, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 13, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 22fc396

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Mar 13, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 13, 2024

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 4c121d7 into tikv:master Mar 13, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 13, 2024
dbsid pushed a commit to dbsid/tikv that referenced this pull request Mar 24, 2024
@yibin87 @dbsid
tidb_query_datatype, tidb_query_expr: Add div_precision_increment sup…
f2399b0 
…port in dag request (tikv#16622)

close tikv#16627, ref pingcap/tidb#51501

Add support for div_precision_increment in dag request.

Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors release-note-none size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Support div_precision_increment in DAGRequest attribute
3 participants
@yibin87 @gengliqi @wshwsh12