Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_backup: store pending region info when giving up retry #16624

Merged
merged 6 commits into from Mar 12, 2024
Merged

log_backup: store pending region info when giving up retry #16624

merged 6 commits into from Mar 12, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 11, 2024 •
edited

What is changed and how it works?

Issue Number: Close #16469, Ref #16554

What's Changed:
This PR rearranged the lifetime of a observed region.
For now, we will try to keep it in subscription tracker from Start until End, even the start itself is failed.
So the RefreshObserver will be able to find and start its observe as expected.

This also added a test case for verifying #16554 has been fixed in master.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause PiTR failed to observe the region.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 11, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YuJuncen
store pending region info when giving up retry
c1d20f1 
Signed-off-by: Yu Juncen <yu745514916@live.com>
@YuJuncen
make clippy happy
198136a 
Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 11, 2024
@3pointer 3pointer self-requested a review March 12, 2024 08:15
3pointer
3pointer approved these changes Mar 12, 2024
View reviewed changes
components/backup-stream/src/subscription_track.rs
/// +-----[Start(Err)]------+
/// +----+ +--------------+
/// v |
/// Absent --------[Start]------> Pending --[Start(OK)]--> Active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could become running too？

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 12, 2024
@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 30e2a78

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Mar 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit faabaa7 into tikv:master Mar 12, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16643.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Mar 13, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16624
8fdb673 
close tikv#16469, ref tikv#16554

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 13, 2024
Closed
9 tasks
dbsid pushed a commit to dbsid/tikv that referenced this pull request Mar 24, 2024
@YuJuncen @ti-chi-bot @dbsid
log_backup: store pending region info when giving up retry (tikv#16624)
d567e47 
close tikv#16469, ref tikv#16554

Signed-off-by: Yu Juncen <yu745514916@live.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request May 7, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16624
e794467 
close tikv#16469, ref tikv#16554

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16955.

@ti-chi-bot ti-chi-bot mentioned this pull request May 7, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.5 release-note size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

pitr checkpoint ts lag reached more than 8h after inject network partition between one of tikv and pd leader
5 participants
@YuJuncen @ti-chi-bot @overvenus @3pointer @Leavrth