Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: add metrics for pending tasks #16657

Merged
merged 10 commits into from
May 7, 2024
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 15, 2024

What is changed and how it works?

Issue Number: Close #16656

What's Changed:

log_backup: add metrics for pending tasks

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: 3pointer <luancheng@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

@BornChanger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

description="The task status of initial scanning.",
targets=[
target(
expr=expr_sum_rate(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a gauge, we don't need to rate over it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: 3pointer <luancheng@pingcap.com>
@purelind
Copy link
Collaborator

/run-clippy-darwin-amd64

Signed-off-by: 3pointer <luancheng@pingcap.com>
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 16, 2024
@YuJuncen
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 33bfd61

@ti-chi-bot ti-chi-bot bot added status/can-merge Status: Can merge to base branch and removed needs-rebase labels Apr 16, 2024
@ti-chi-bot ti-chi-bot bot removed status/can-merge Status: Can merge to base branch needs-rebase labels Apr 18, 2024
@YuJuncen
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 563e130

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 18, 2024
@YuJuncen
Copy link
Contributor

YuJuncen commented May 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 4df8203

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 7, 2024
@3pointer
Copy link
Contributor Author

3pointer commented May 7, 2024

/test pull-unit-test

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

@3pointer: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 9fcd8bb into tikv:master May 7, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: add metrics tikv_log_backup_pending_initial_scan to grafana panel
5 participants