Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-memory engine: fix panic when write batch callback twice #16691

Merged
merged 3 commits into from Mar 26, 2024
Merged

In-memory engine: fix panic when write batch callback twice #16691

merged 3 commits into from Mar 26, 2024

Conversation

SpadeA-Tang
Copy link
Member

@SpadeA-Tang SpadeA-Tang commented Mar 25, 2024 •
edited

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:

fix panic when write batch callback twice

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@SpadeA-Tang
done
b8f4c85 
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LykxSassinator
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

afeinberg
afeinberg approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@afeinberg afeinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. /cc @tonyxuqqi to merge it.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 25, 2024

@afeinberg: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM. /cc @tonyxuqqi to merge it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Mar 26, 2024
@SpadeA-Tang
address comment
f62c621 
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@ti-chi-bot ti-chi-bot bot added size/XS and removed size/S labels Mar 26, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Mar 26, 2024
@SpadeA-Tang
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

@SpadeA-Tang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: eec05db

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Mar 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3acb9dd into tikv:master Mar 26, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 26, 2024
hongyunyan pushed a commit to hongyunyan/tikv that referenced this pull request Mar 28, 2024
@SpadeA-Tang @hongyunyan
In-memory engine: fix panic when write batch callback twice (tikv#16691)
2786881 
ref tikv#16141

fix panic when write batch callback twice

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afeinberg afeinberg afeinberg approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpadeA-Tang @afeinberg @tonyxuqqi @LykxSassinator