Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: make a more rusty CallbackWaitGroup #16740

Merged
merged 4 commits into from Apr 3, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Apr 2, 2024

What is changed and how it works?

Issue Number: Close #16739

What's Changed:

This make `CallbackWaitGroup` returns an equivalent future of the `BoxFuture` returned by `wait`. Also this fixed where a stale notify may also resolve the future.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    I ran the task for 100 times. No error happens anymore.
for i in (seq 100)
   if ! cargo test --package backup-stream --lib -- utils::test::test_wait_group --exact
       break
   end
   echo "passed $i"
end
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug where make there are a slight possibility that log backup lost a few records.

Signed-off-by: Yu Juncen <yu745514916@live.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 3, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 3, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 60c93a8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 81d62b2 into tikv:master Apr 3, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 3, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 3, 2024

/run-cherry-pciker

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 3, 2024

/run-cheery-pciker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16755.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 3, 2024
close tikv#16739

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16756.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 3, 2024
close tikv#16739

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16757.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 3, 2024
close tikv#16739

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 3, 2024
close #16739

This make `CallbackWaitGroup` returns an equivalent future of the `BoxFuture` returned by `wait`. Also this fixed where a stale notify may also resolve the future.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Yu Juncen <yu745514916@live.com>
Co-authored-by: hillium <yujuncen@pingcap.com>
ti-chi-bot bot added a commit that referenced this pull request Apr 18, 2024
close #16739

This make `CallbackWaitGroup` returns an equivalent future of the `BoxFuture` returned by `wait`. Also this fixed where a stale notify may also resolve the future.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: hillium <yu745514916@live.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_backup: the type CallbackWaitGroup is error-prone
5 participants