Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Fix h2 cargo deny issue. #16769

Merged
merged 1 commit into from Apr 4, 2024

Conversation

afeinberg
Copy link
Contributor

@afeinberg afeinberg commented Apr 3, 2024

What is changed and how it works?

Issue Number: Close #16768

What's Changed:

Update h2 to 0.3.26

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
make clippy
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: Alex Feinberg <alex@strlen.net>
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none contribution Type: PR - From contributors labels Apr 3, 2024
@afeinberg
Copy link
Contributor Author

/assign @tonyxuqqi

@afeinberg
Copy link
Contributor Author

/cc @tonyxuqqi @v01dstar

@ti-chi-bot ti-chi-bot bot requested review from tonyxuqqi and v01dstar April 3, 2024 22:22
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 3, 2024
@afeinberg
Copy link
Contributor Author

Could someone do a /merge? /cc @bufferflies @Connor1996

@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 4, 2024
@bufferflies
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 4, 2024

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 57a0928

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 694e4ab into tikv:master Apr 4, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo build fails due to vulnerability in h2
3 participants