Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/node: rename Node to MultiRaftServer #16783

Merged
merged 5 commits into from Apr 12, 2024
Merged

server/node: rename Node to MultiRaftServer #16783

merged 5 commits into from Apr 12, 2024

Conversation

zhangjinpeng87
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 commented Apr 8, 2024 •
edited

What is changed and how it works?

Issue Number: Close #16782

What's Changed:

Rename Node to a better name MultiRaftServer.

Related changes

  • None

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • None

Release note

None

@zhangjinpeng87
server/node: rename Node to RaftServer
77956cf 
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SpadeA-Tang
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/L label Apr 8, 2024
@LykxSassinator
Copy link
Contributor

IMO, RaftStore sounds better than RaftServer for TiKV, considering TiKV's multiple raft groups.

Referring to a single RaftServer may give the impression that it serves only one raft group.

tonyxuqqi
tonyxuqqi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@tonyxuqqi tonyxuqqi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe RaftStore as the name?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 9, 2024
@zhangjinpeng87
Copy link
Member Author

IMO, RaftStore sounds better than RaftServer for TiKV, considering TiKV's multiple raft groups.

Referring to a single RaftServer may give the impression that it serves only one raft group.

RaftStore is a name that vague, instead I prefer MultiRaftServer to express the MultiRaft semantic.

@zhangjinpeng87
rename RaftServer to MultiRaftServer to express semantic
10ee52c 
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
@zhangjinpeng87
format code
20e742c 
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
@zhangjinpeng87 zhangjinpeng87 changed the title server/node: rename Node to RaftServer server/node: rename Node to MultiRaftServer Apr 9, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 10, 2024
LykxSassinator
LykxSassinator reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

zhangjinpeng87 and others added 2 commits April 12, 2024 10:50
@zhangjinpeng87 @LykxSassinator
Update src/server/raft_server.rs
1b0a628 
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com>
@zhangjinpeng87
Merge branch 'master' into rename-node
13c8b52
@zhangjinpeng87 zhangjinpeng87 added the status/can-merge Status: Can merge to base branch label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Status: Can merge to base branch label Apr 12, 2024
@zhangjinpeng87
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

@zhangjinpeng87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 13c8b52

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit b1715ea into tikv:master Apr 12, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 12, 2024
glorv pushed a commit to glorv/tikv that referenced this pull request Apr 15, 2024
@zhangjinpeng87 @LykxSassinator @glorv
server/node: rename Node to MultiRaftServer (tikv#16783)
b164c1f 
close tikv#16782

Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
Signed-off-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LykxSassinator LykxSassinator LykxSassinator left review comments

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@SpadeA-Tang SpadeA-Tang SpadeA-Tang approved these changes

Assignees
No one assigned
Labels
release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Rename Node to a better name
4 participants
@zhangjinpeng87 @LykxSassinator @tonyxuqqi @SpadeA-Tang