Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: use u64::MAX as txn_size for Flush commands #16811

Merged
merged 1 commit into from Apr 12, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Apr 11, 2024

What is changed and how it works?

Issue Number: Close #16810

What's Changed:

fix: use u64::MAX as txn_size for Flush commands to avoid unexpected resolve_lock_lite

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

…resolve_lock_lite

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested a review from cfzjywxk April 11, 2024 11:23
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Collaborator

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 11, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 12, 2024
@ekexium
Copy link
Contributor Author

ekexium commented Apr 12, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

@ekexium: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9b0c9b9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0151ee3 into tikv:master Apr 12, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 12, 2024
ekexium added a commit to ekexium/tikv that referenced this pull request Apr 23, 2024
close tikv#16810

fix: use u64::MAX as txn_size for Flush commands to avoid unexpected resolve_lock_lite

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #16900.

ti-chi-bot bot added a commit that referenced this pull request Apr 24, 2024
close #16810

fix: use u64::MAX as txn_size for Flush commands to avoid unexpected resolve_lock_lite

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-8.1 release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelined-DML uses resolve_lock_lite instead of resolve_lock when there is conflict
4 participants