Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile memory-engine by default and support dynamic config update for memory-engine #16897

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

tonyxuqqi
Copy link
Contributor

@tonyxuqqi tonyxuqqi commented Apr 22, 2024

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:

compile the in-memory-engine by default and support dynamic config update for memory-engine.
The enabled flag would support enabled:true -> enabled:false and soft/hard limit also supports online change. 
But if enabled:false is set initially, the config change to make enabled:true needs the TiKV restart. 

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Side effects

Release note

Make range-cache-engine.enabled, range-cache-engine.soft-limit-threshold, range-cache-engine.hard-limit-threshold dynamic updatable. 

Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SpadeA-Tang
  • zhangjinpeng87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

@afeinberg: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 22, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 24, 2024
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/XS labels Apr 24, 2024
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@tonyxuqqi tonyxuqqi changed the title compile memory-engine by default compile memory-engine by default and support dynamic config update for memory-engine Apr 25, 2024
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

@afeinberg: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@tonyxuqqi
Copy link
Contributor Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

@tonyxuqqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 55af5e8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2118288 into tikv:master Apr 25, 2024
5 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XL status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants