New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr/expr: optimize like #2293
copr/expr: optimize like #2293
Conversation
src/coprocessor/dag/expr/compare.rs
Outdated
} | ||
} | ||
}; | ||
let next_pattern = pcs.as_str(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary?
src/coprocessor/dag/expr/compare.rs
Outdated
if t == c || (c == '_' && (!escaped || escape == '%')) { | ||
continue; | ||
} | ||
let mut skip_cnt = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip_cnt looks like also useless.
LGTM. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
This pr tries to optimize like by
According to bench, average match time is 2/3 less than before.