New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr/expr: optimize like #2293

Merged
merged 6 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 14, 2017

This pr tries to optimize like by

  • reducing recurses as many as possible
  • reducing match as many as possible

According to bench, average match time is 2/3 less than before.

@BusyJay BusyJay requested review from AndreMouche and hicqu Sep 14, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 14, 2017

Contributor

LGTM.

Contributor

hicqu commented Sep 14, 2017

LGTM.

BusyJay added some commits Sep 14, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 14, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 14, 2017

/run-all-tests

@AndreMouche

LGTM

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 15, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 15, 2017

/run-all-tests

@BusyJay BusyJay merged commit 296e447 into master Sep 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/optimize-like branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment