New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coprocessor: select response of dag don't need row meta. #2302
Merged
Merged
Changes from 16 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
593d477
coprocessor: select response of dag don't need row meta.
winoros 3462bbd
don't send group by key if there isn't
winoros 0bdea39
Merge branch 'master' into yiding/handle
winoros 92f2ffa
format code
winoros d104ed1
Merge branch 'master' into yiding/handle
winoros eb18d46
Merge branch 'master' into yiding/handle
AndreMouche 9d4175f
modify tests
winoros 7396b28
Merge branch 'yiding/handle' of https://github.com/pingcap/tikv into …
winoros 6ce44f5
Merge branch 'master' into yiding/handle
winoros 8764374
Merge branch 'master' into yiding/handle
AndreMouche f1bd8d7
Merge branch 'yiding/handle' of https://github.com/pingcap/tikv into …
winoros 23ea73d
address comments
winoros ac31337
Merge branch 'master' into yiding/handle
AndreMouche dfe3880
Merge branch 'master' into yiding/handle
AndreMouche c51fc53
Merge branch 'master' into yiding/handle
winoros d2c2b8b
address comment
winoros 6d03f79
address some comments
winoros b50cd01
Merge branch 'master' into yiding/handle
AndreMouche 069d253
make it correct.
winoros bf589ae
Merge branch 'yiding/handle' of https://github.com/pingcap/tikv into …
winoros 5397f69
address comment
winoros abf6183
Merge branch 'master' into yiding/handle
hicqu e20d356
Merge branch 'master' into yiding/handle
shenli c32c139
Merge branch 'master' into yiding/handle
winoros fb0c7ec
Merge branch 'master' into yiding/handle
AndreMouche File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems different with
aggregation
inselect
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is no group by column, group_key is redundant, and since we no longer transfer rowMeta, redundant value shouldn't be sent to tidb.