New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some metrics #2323

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@huachaohuang
Member

huachaohuang commented Sep 20, 2017

No description provided.

STORE_ENGINE_NUM_SNAPSHOTS_GAUGE.set(n as f64);
}
if let Some(t) = engine.get_property_int(ROCKSDB_OLDEST_SNAPSHOT_TIME) {
let d = time::get_time().sec.checked_sub(t as i64).unwrap_or(0);

This comment has been minimized.

@siddontang

siddontang Sep 20, 2017

Contributor

the time is second?

@siddontang

siddontang Sep 20, 2017

Contributor

the time is second?

This comment has been minimized.

@huachaohuang
@huachaohuang
@siddontang

Rest LGTM

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 20, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 20, 2017

/rebuild

pub const ENGINE_TICKER_TYPES: &'static [TickerType] = &[
TickerType::BlockCacheMiss,
TickerType::BlockCacheHit,
TickerType::BlockCacheAdd,
TickerType::BlockCacheAddFailures,

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Sep 21, 2017

Member

Can we get the failure reason?

@zhangjinpeng1987

zhangjinpeng1987 Sep 21, 2017

Member

Can we get the failure reason?

This comment has been minimized.

@siddontang

siddontang Sep 21, 2017

Contributor

seem can't

@siddontang

siddontang Sep 21, 2017

Contributor

seem can't

@zhangjinpeng1987

This comment has been minimized.

Show comment
Hide comment
@zhangjinpeng1987
Member

zhangjinpeng1987 commented Sep 21, 2017

LGTM

@huachaohuang huachaohuang merged commit 032513c into master Sep 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@huachaohuang huachaohuang deleted the huachao/statistics branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment