Add some metrics #2323
Merged
Add some metrics #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Sep 20, 2017
| STORE_ENGINE_NUM_SNAPSHOTS_GAUGE.set(n as f64); | ||
| } | ||
| if let Some(t) = engine.get_property_int(ROCKSDB_OLDEST_SNAPSHOT_TIME) { | ||
| let d = time::get_time().sec.checked_sub(t as i64).unwrap_or(0); |
|
/rebuild |
|
|
||
| pub const ENGINE_TICKER_TYPES: &'static [TickerType] = &[ | ||
| TickerType::BlockCacheMiss, | ||
| TickerType::BlockCacheHit, | ||
| TickerType::BlockCacheAdd, | ||
| TickerType::BlockCacheAddFailures, |
There was a problem hiding this comment.
Can we get the failure reason?
|
LGTM |
huachaohuang
force-pushed
the
huachao/statistics
branch
from
b7d2dfe
to
3f9c0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.