New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refactor split check #2440

Merged
merged 38 commits into from Nov 2, 2017

Conversation

Projects
None yet
4 participants
@overvenus
Member

overvenus commented Oct 31, 2017

Move size split check from SplitCheckRunner to CoprocessorHost. It also move region-max-size and region-split-size to coprocessor configuration.

Ref #2378

overvenus added some commits Oct 12, 2017

@overvenus overvenus requested review from siddontang and BusyJay Oct 31, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Oct 31, 2017

Contributor

No need to support compatible config file.

Contributor

siddontang commented Oct 31, 2017

No need to support compatible config file.

overvenus added some commits Oct 31, 2017

Show outdated Hide outdated etc/config-template.toml
# When the region's size exceeds region-max-size, we will split the region
# into two which the left region's size will be region-split-size or a little
# bit smaller.
# region-max-size = "144MB"

This comment has been minimized.

@BusyJay

BusyJay Oct 31, 2017

Contributor

If this is set, then coprocessor.region-max-size should be updated too.

@BusyJay

BusyJay Oct 31, 2017

Contributor

If this is set, then coprocessor.region-max-size should be updated too.

Show outdated Hide outdated src/raftstore/store/config.rs
Show outdated Hide outdated src/raftstore/store/keys.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Nov 1, 2017

Contributor

LGTM

Contributor

siddontang commented Nov 1, 2017

LGTM

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Nov 1, 2017

Member

/run-all-test

Member

overvenus commented Nov 1, 2017

/run-all-test

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Nov 1, 2017

Contributor

LGTM

Contributor

BusyJay commented Nov 1, 2017

LGTM

overvenus added some commits Nov 1, 2017

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Nov 1, 2017

Member

/run-all-test

Member

overvenus commented Nov 1, 2017

/run-all-test

@@ -138,6 +133,13 @@
# Interval (s) to check region whether the data are consistent.
# consistency-check-interval = 0
[coprocessor]

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Nov 2, 2017

Member

I think this will confuse ops.

@zhangjinpeng1987

zhangjinpeng1987 Nov 2, 2017

Member

I think this will confuse ops.

@overvenus overvenus merged commit 1084f94 into tikv:master Nov 2, 2017

6 of 7 checks passed

jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the overvenus:split-table-part1 branch Nov 2, 2017

@overvenus overvenus restored the overvenus:split-table-part1 branch Nov 2, 2017

@overvenus overvenus deleted the overvenus:split-table-part1 branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment