*: refactor split check #2440
Merged
*: refactor split check #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Oct 31, 2017
tests/config/test-custom-latest.toml
Outdated
| @@ -73,6 +71,10 @@ raft-store-max-leader-lease = "12s" | |||
| right-derive-when-split = false | |||
| allow-remove-leader = true | |||
|
|
|||
| [coprocessor] | |||
| region-max-size = "12MB" | |||
There was a problem hiding this comment.
Do we need to update ansible?
|
No need to support compatible config file. |
overvenus
force-pushed
the
split-table-part1
branch
from
f5c4927
to
341b9c0
Compare
overvenus
force-pushed
the
split-table-part1
branch
from
0e694ac
to
9a54c40
Compare
BusyJay
reviewed
Oct 31, 2017
etc/config-template.toml
Outdated
| [coprocessor] | ||
| # When it is true, it will try to split a region with table prefix if | ||
| # that region crosses tables. | ||
| # split-region-on-table = false |
| # When the region's size exceeds region-max-size, we will split the region | ||
| # into two which the left region's size will be region-split-size or a little | ||
| # bit smaller. | ||
| # region-max-size = "144MB" |
There was a problem hiding this comment.
If this is set, then coprocessor.region-max-size should be updated too.
overvenus
force-pushed
the
split-table-part1
branch
from
a083df3
to
ac89022
Compare
BusyJay
reviewed
Oct 31, 2017
src/bin/tikv-server.rs
Outdated
| @@ -463,6 +463,7 @@ fn main() { | |||
| if let Err(e) = config.validate() { | |||
| fatal!("invalid configuration: {:?}", e); | |||
| } | |||
| config.compatible_adjust(); | |||
There was a problem hiding this comment.
Should adjust before validating.
overvenus
force-pushed
the
split-table-part1
branch
from
acd7c0a
to
52211d4
Compare
BusyJay
reviewed
Oct 31, 2017
src/raftstore/store/config.rs
Outdated
| @@ -202,6 +200,15 @@ impl Config { | |||
| )); | |||
| } | |||
|
|
|||
| // Compatibility check. | |||
| if self.region_max_size.0 != 0 { | |||
| warn!("raftstore.region-max-size has been moved to coprocessor"); | |||
src/raftstore/store/keys.rs
Outdated
| @@ -195,7 +195,7 @@ pub fn data_key(key: &[u8]) -> Vec<u8> { | |||
| } | |||
|
|
|||
| pub fn origin_key(key: &[u8]) -> &[u8] { | |||
| assert!(validate_data_key(key)); | |||
| assert!(validate_data_key(key), "invalid data key {:?}", key); | |||
|
LGTM |
overvenus
force-pushed
the
split-table-part1
branch
from
b442760
to
ac48aef
Compare
|
/run-all-test |
siddontang
approved these changes
Nov 1, 2017
|
LGTM |
overvenus
force-pushed
the
split-table-part1
branch
from
b8fa35f
to
19afb85
Compare
|
/run-all-test |
| @@ -138,6 +133,13 @@ | |||
| # Interval (s) to check region whether the data are consistent. | |||
| # consistency-check-interval = 0 | |||
|
|
|||
| [coprocessor] | |||
There was a problem hiding this comment.
I think this will confuse ops.
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Move size split check from SplitCheckRunner to CoprocessorHost. It also move region-max-size and region-split-size to coprocessor configuration. Ref tikv#2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move size split check from SplitCheckRunner to CoprocessorHost. It also move
region-max-sizeandregion-split-sizeto coprocessor configuration.Ref #2378