Output Unit "Byte" for tikv-ctl #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
hicqu
reviewed
Aug 9, 2018
src/bin/tikv-ctl.rs
Outdated
| @@ -1805,7 +1805,7 @@ fn convert_gbmb(mut bytes: u64) -> String { | |||
| const GB: u64 = 1024 * 1024 * 1024; | |||
| const MB: u64 = 1024 * 1024; | |||
| if bytes < MB { | |||
| return bytes.to_string(); | |||
| return format!("{} Byte ", bytes); | |||
There was a problem hiding this comment.
How about write the logic in convert_gbmb?
There was a problem hiding this comment.
I think {} B is enough. see https://en.wikipedia.org/wiki/File_size
There was a problem hiding this comment.
@siddontang OK, I changed unit Byte to B.
Hoverbear
previously approved these changes
Aug 9, 2018
|
@smallyard Thank you for this patch! :) |
hicqu
previously approved these changes
Aug 10, 2018
|
Please add a new commit log to pass DCO check. |
smallyard
dismissed stale reviews from hicqu, zhangjinpeng87, and Hoverbear
via
62c669e
|
@hicqu I add a commit whih argument -s, but the check still not pass. |
|
@zhangjinpeng1987 please approve it |
breezewish
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Output Unit "Byte" for tikv-ctl
What are the type of the changes? (mandatory)
Improvement
How has this PR been tested? (mandatory)
manual tests
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
#3186