expr/builtin_fncall: implement Inet6Aton #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sweetIan <ian.d2d@qq.com>
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
hicqu
reviewed
Aug 20, 2018
| let input = try_opt!(self.children[0].eval_string_and_decode(ctx, row)); | ||
| let ipv6_addr = Ipv6Addr::from_str(&input).map(|t| Some(Cow::Owned(t.octets().to_vec()))); | ||
| let ipv4_addr = Ipv4Addr::from_str(&input).map(|t| Some(Cow::Owned(t.octets().to_vec()))); | ||
| ipv6_addr.or(ipv4_addr).or(Ok(None)) |
There was a problem hiding this comment.
Please use or_else instead of or.
There was a problem hiding this comment.
@hicqu Do you mean that we need to lazy evaluate ipv4_addr? How about write it as below?
let input = try_opt!(self.children[0].eval_string_and_decode(ctx, row));
let ipv6_addr = Ipv6Addr::from_str(&input).map(|t| Some(Cow::Owned(t.octets().to_vec())));
let ipv4_addr_eval =
|_t| Ipv4Addr::from_str(&input).map(|t| Some(Cow::Owned(t.octets().to_vec())));
ipv6_addr.or_else(ipv4_addr_eval).or(Ok(None))
|
rest LGTM. PTAL @breeswish . |
Signed-off-by: sweetIan <ian.d2d@qq.com>
|
LGTM. |
hicqu
approved these changes
Aug 21, 2018
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: sweetIan <ian.d2d@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sweetIan ian.d2d@qq.com
What have you changed? (mandatory)
expr/builtin_fncall: implement Inet6Aton
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
#3275