Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix some tikv-ctl parameters #3639

Merged
merged 3 commits into from
Oct 9, 2018
Merged

docs: fix some tikv-ctl parameters #3639

merged 3 commits into from
Oct 9, 2018

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 28, 2018 •
edited

What have you changed? (mandatory)

This PR fixes some tikv-ctl parameters in documentation.

Refer to a related PR or issue link (optional)

Related to pingcap/docs#637.

@rleungx
fix some tikv-ctl parameters
de1d615 
Signed-off-by: rleungx <rleungx@gmail.com>
Hoverbear
Hoverbear previously requested changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think leaving the long parameter names is better in documentation.

@rleungx
Copy link
Member Author

rleungx commented Sep 29, 2018 •
edited

@Hoverbear

tikv-ctl-unsafe-recover-remove-fail-stores

USAGE:
    tikv-ctl unsafe-recover remove-fail-stores [FLAGS] --all-regions -r <regions>... -s <stores>...

FLAGS:
        --all-regions    do the command for all regions
    -h, --help           Prints help information
    -V, --version        Prints version information

OPTIONS:
    -r <regions>...        only for these regions
    -s <stores>...         stores to be removed

Seems we don't support the long parameter for those things.

lilin90
lilin90 approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siddontang
siddontang approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000 ice1000 added the component/documentation Component: Documentation label Sep 30, 2018
@breezewish breezewish added the status/LGT2 Status: PR - There are already 2 approvals label Oct 8, 2018
@Connor1996 Connor1996 merged commit 5ac5a33 into tikv:master Oct 9, 2018
@lilin90 lilin90 mentioned this pull request Oct 9, 2018
Merged
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
@rleungx @Connor1996
fix some tikv-ctl parameters (tikv#3639)
9fe500c 
Signed-off-by: rleungx <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@lilin90 lilin90 lilin90 approved these changes

@Hoverbear Hoverbear Hoverbear left review comments

Assignees
No one assigned
Labels
component/documentation Component: Documentation status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rleungx @Hoverbear @siddontang @Connor1996 @lilin90 @breezewish @ice1000