Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CompactFiles bug #3789

Merged
merged 1 commit into from Nov 15, 2018
Merged

Conversation

DorianZheng
Copy link
Contributor

Signed-off-by: DorianZheng xingzhengde72@gmail.com

What have you changed? (mandatory)

Just Upgrade rocksdb version

What are the type of the changes? (mandatory)

  • Bug fix

How has this PR been tested? (mandatory)

test case

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
@huachaohuang
Copy link
Contributor

/run-all-tests tidb=release-2.0 pd=release-2.0 tidb-test=release-2.0 tidb-private-test=release-2.0

Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87
Copy link
Member

zhangjinpeng87 commented Nov 15, 2018

@overvenus Please take a look at the failed test case test_lease.

@overvenus
Copy link
Member

Cc #3044

@huachaohuang huachaohuang merged commit 125f9b4 into tikv:release-2.0 Nov 15, 2018
@huachaohuang
Copy link
Contributor

So I think the failed test has nothing to do with this PR, merge now.

@DorianZheng DorianZheng deleted the release-2.0-bug-fix branch November 15, 2018 06:11
@sre-bot sre-bot added the contribution Type: PR - From contributors label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants