Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd/client: retry validating the endpoints when creating RPC client #3851

Merged
merged 7 commits into from Jan 3, 2019
Merged

pd/client: retry validating the endpoints when creating RPC client #3851

merged 7 commits into from Jan 3, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Nov 28, 2018 •
edited

Signed-off-by: nolouch nolouch@gmail.com

What have you changed? (mandatory)

fix #3827, retry connect the PD. no need to sleep.

./bin/pd-server  --data-dir=pd --log-file=pd.log &
sleep 5
./bin/tikv-server --pd="127.0.0.1:2379" --data-dir=tikv -A 127.0.0.1:20165 --log-file=tikv.log &
sleep 5
./bin/tidb-server --store=tikv --path="127.0.0.1:2379"

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Manual test

@rleungx rleungx added the type/enhancement Type: Issue - Enhancement label Nov 29, 2018
@siddontang
Copy link
Contributor

do we need to add unit test?

@nolouch
add test
b46f379 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Dec 11, 2018

PTAL @overvenus @Connor1996

Connor1996
Connor1996 previously approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
address comments
1774528 
Signed-off-by: nolouch <nolouch@gmail.com>
overvenus
overvenus approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus added the status/LGT2 Status: PR - There are already 2 approvals label Jan 3, 2019
@Connor1996 Connor1996 merged commit 9b97668 into tikv:master Jan 3, 2019
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
@nolouch @Connor1996
pd/client: retry validating the endpoints when creating RPC client (t…
04789f5 
…ikv#3851)

* pd/client: retry validating the endpoints when creating RPC client

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@rleungx rleungx rleungx approved these changes

@Connor1996 Connor1996 Connor1996 left review comments

Assignees
No one assigned
Labels
status/LGT2 Status: PR - There are already 2 approvals type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry connecting to pd on startup
5 participants
@nolouch @siddontang @overvenus @Connor1996 @rleungx