New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd/client: retry validating the endpoints when creating RPC client #3851

Merged
merged 7 commits into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@nolouch
Copy link
Contributor

nolouch commented Nov 28, 2018

Signed-off-by: nolouch nolouch@gmail.com

What have you changed? (mandatory)

fix #3827, retry connect the PD. no need to sleep.

./bin/pd-server  --data-dir=pd --log-file=pd.log &
sleep 5
./bin/tikv-server --pd="127.0.0.1:2379" --data-dir=tikv -A 127.0.0.1:20165 --log-file=tikv.log &
sleep 5
./bin/tidb-server --store=tikv --path="127.0.0.1:2379"

What are the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Manual test

pd/client: retry validating the endpoints when creating RPC client
Signed-off-by: nolouch <nolouch@gmail.com>

@nolouch nolouch requested a review from overvenus Nov 28, 2018

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Dec 3, 2018

do we need to add unit test?

add test
Signed-off-by: nolouch <nolouch@gmail.com>

@nolouch nolouch requested a review from Connor1996 Dec 11, 2018

@nolouch

This comment has been minimized.

Copy link
Contributor

nolouch commented Dec 11, 2018

@Connor1996
Copy link
Member

Connor1996 left a comment

LGTM

address comments
Signed-off-by: nolouch <nolouch@gmail.com>
@overvenus
Copy link
Member

overvenus left a comment

LGTM

@overvenus overvenus added the S: LGT2 label Jan 3, 2019

@Connor1996 Connor1996 merged commit 9b97668 into tikv:master Jan 3, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment