raftstore: reject transfer leader to the recently added peers #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connor1996
reviewed
Dec 5, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
saft-transfer
branch
2 times, most recently
from
41cc231
to
d87203e
Compare
nolouch
force-pushed
the
saft-transfer
branch
from
d87203e
to
f4ac4f6
Compare
BusyJay
reviewed
Dec 5, 2018
|
em, can the leader know the applied index of the followers so that we can do a more accurate control? |
|
@siddontang Currently, the apply index can only be known by itself. If need precise control, should change it in the raft library. This is a quick fix, and the long-term solution maybe is this. |
|
I prefer to do a quick fix for now. And make it better later. |
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
saft-transfer
branch
from
d15a8ea
to
554cc21
Compare
|
This still has the risk that the learner drops the transfer leader message if the learner applies too slow. /cc @BusyJay |
|
Yes, it does. But it should be hardly possible. |
overvenus
reviewed
Dec 5, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
saft-transfer
branch
from
a30ecb5
to
c958715
Compare
|
Good job. |
Signed-off-by: nolouch <nolouch@gmail.com>
BusyJay
reviewed
Dec 6, 2018
src/raftstore/store/fsm/peer.rs
Outdated
| @@ -893,6 +893,10 @@ impl<T: Transport, C: PdClient> Store<T, C> { | |||
| if p.is_leader() { | |||
| p.peers_start_pending_time.push((id, now)); | |||
| } | |||
| // Add peer or promote the learner | |||
| if !peer.get_is_learner() { | |||
There was a problem hiding this comment.
I think only leader needs to do this.
There was a problem hiding this comment.
Maybe transfer From A to B then to Cnew.
Signed-off-by: nolouch <nolouch@gmail.com>
BusyJay
reviewed
Dec 7, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
saft-transfer
branch
from
962695f
to
95890c2
Compare
BusyJay
approved these changes
Dec 7, 2018
nolouch
added a commit
to nolouch/tikv
that referenced
this pull request
Dec 8, 2018
nolouch
added a commit
that referenced
this pull request
Dec 8, 2018
nolouch
added a commit
to nolouch/tikv
that referenced
this pull request
Dec 14, 2018
rleungx
pushed a commit
that referenced
this pull request
Dec 14, 2018
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
The apply state not consistent with the leader, transfer leader to newly added peer probable failed . reject transfer leader to the recently added peers to prevent transferring failed.
This is a quick fix, need remove after tikv/raft-rs#144 sloved.
ref: #3819
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit test.
manua test:
master(before) vs bransh(after):
prepare: add a special hot scheduler that move hot region and transfer the leader to the newly added hot peer. run oltp test.
result: