util/timer: introduce steady timer #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steady timer is used to create futures that is notified after a given duration. It's called steady because it won't be affected by the time adjustment. This is important for raftstore as the lease mechanism is based on a steady time. Signed-off-by: Jay Lee <busyjaylee@gmail.com>
BusyJay
added
priority/critical
overvenus
reviewed
Jan 11, 2019
src/util/timer.rs
Outdated
| let clock = SteadyClock::default(); | ||
| let clock_ = clock.clone(); | ||
| Builder::new() | ||
| .name(thd_name!("steady timer")) |
There was a problem hiding this comment.
Please rename to steady-timer
There was a problem hiding this comment.
Seems it can also take time-monitor thread's job checks if time jumps back, but it can be left for future work.
src/util/timer.rs
Outdated
| } | ||
|
|
||
| impl SteadyTimer { | ||
| /// Create a delay future that will be notified after the given duration. |
There was a problem hiding this comment.
Suggested change
| /// Create a delay future that will be notified after the given duration. | |
| /// Creates a delay future that will be notified after the given duration. |
|
|
||
| impl SteadyTimer { | ||
| /// Create a delay future that will be notified after the given duration. | ||
| pub fn delay(&self, dur: Duration) -> Delay { |
There was a problem hiding this comment.
Do every leader need to create a Delay?
|
Why not keep the old style of lease renewal that renew lease by propoals? |
|
It's for tick scheduling instead of lease. |
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
|
/run-integration-tests |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Steady timer is used to create futures that is notified after a given duration. It's called steady because it won't be affected by the time adjustment. This is important for raftstore as the lease mechanism is based on a steady time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steady timer is used to create futures that is notified after a given
duration. It's called steady because it won't be affected by the time
adjustment. This is important for raftstore as the lease mechanism is
based on a steady time.