implement builtin_string/instr_binary #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TigerInYourDreams <TigerInYourDream@hi.zy>
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
zhangjinpeng87
added
sig/coprocessor
ice1000
approved these changes
Mar 10, 2019
| match s.find(&substr) { | ||
| Some(x) => Ok(Some(1 + s[..x].chars().count() as i64)), | ||
| None => Ok(Some(0)), | ||
| } |
There was a problem hiding this comment.
Can extract the Ok(Some( part:
Ok(Some(match s.find(&substr) {
Some(x) => 1 + s[..x].chars().count() as i64,
None => 0,
}))
AndreMouche
reviewed
Mar 11, 2019
| ("F", "abcdefg", 0), | ||
| ("cd", "abcdefg", 3), | ||
| (" ", "abcdefg", 0), | ||
| ("", "", 0), |
There was a problem hiding this comment.
@AndreMouche Thanks for the review.The same problem in #4337 .
AndreMouche
added a commit
that referenced
this pull request
Mar 11, 2019
This reverts commit 5a296bc.
AndreMouche
reviewed
Mar 11, 2019
| row: &'a [Datum], | ||
| ) -> Result<Option<i64>> { | ||
| let s = try_opt!(self.children[0].eval_string_and_decode(ctx, row)); | ||
| let substr = try_opt!(self.children[1].eval_string_and_decode(ctx, row)); |
There was a problem hiding this comment.
I think we needn't decode it since it is a binary.
|
@TigerInYourDream Would you like to fix the bug? |
@AndreMouche My bad.I'll create new pr to fix it. Thanks for your help. |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: TigerInYourDreams <TigerInYourDream@hi.zy>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TigerInYourDreams TigerInYourDream@hi.zy
What have you changed? (mandatory)
Implement the function instr_binary which I found in #3275
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Add instr_binary function.
What are the type of the changes? (mandatory)
Add function。
The currently defined types are listed below, please pick one of the types for this PR by removing the others:
How has this PR been tested? (mandatory)
Unit Test。
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No