*: add a procedure that upgrades data from v2 to v3 #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
5kbpers
previously approved these changes
Mar 18, 2019
|
LGTM |
BusyJay
reviewed
Mar 19, 2019
src/raftstore/store/keys.rs
Outdated
| pub fn decode_region_meta_key(key: &[u8]) -> Result<(u64, u8)> { | ||
| if REGION_META_PREFIX_KEY.len() + mem::size_of::<u64>() + mem::size_of::<u8>() != key.len() { | ||
| /// Decode region key, return the region id and meta suffix type. | ||
| fn decode_region_key(prefix: &[u8], key: &[u8], which: &str) -> Result<(u64, u8)> { |
Signed-off-by: Neil Shen <overvenus@gmail.com>
BusyJay
reviewed
Mar 21, 2019
src/raftstore/store/peer_storage.rs
Outdated
| // Create v2.0.x kv engine. | ||
| let kv_cfs_opts = kv_cfg.build_cf_opts_v2(); | ||
| let mut kv_engine = util::rocksdb_util::new_engine_opt(kv_path, kv_db_opts, kv_cfs_opts) | ||
| .unwrap_or_else(|s| panic!("failed to create kv engine: {}", s)); |
There was a problem hiding this comment.
Better return error and let outside to decide to panic or fatal.
src/raftstore/store/keys.rs
Outdated
| pub fn decode_region_meta_key(key: &[u8]) -> Result<(u64, u8)> { | ||
| if REGION_META_PREFIX_KEY.len() + mem::size_of::<u64>() + mem::size_of::<u8>() != key.len() { | ||
| /// Decode region category key, return the region id and meta suffix type. | ||
| fn decode_region_category_key(prefix: &[u8], key: &[u8], which: &str) -> Result<(u64, u8)> { |
There was a problem hiding this comment.
Oh, what I mean is which is meaningless without context.
Signed-off-by: Neil Shen <overvenus@gmail.com>
BusyJay
reviewed
Mar 22, 2019
src/raftstore/store/peer_storage.rs
Outdated
| } else if let Ok((region_id, suffix)) = keys::decode_region_meta_key(key) { | ||
| if suffix == keys::REGION_STATE_SUFFIX { | ||
| upgrade_raft_wb.put(key, value)?; | ||
| info!("upgrading region state"; "region_id" => region_id, "value" => ?value); |
Signed-off-by: Neil Shen <overvenus@gmail.com>
BusyJay
approved these changes
Mar 22, 2019
5kbpers
approved these changes
Mar 22, 2019
overvenus
added
status/LGT2
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
In v3.x, we move all meta data to raft engine and remove RAFT CF of kv engine. This is a precede change of #4372 , it add a procedure that upgrades data from v2 to v3:
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Unit tests and integration tests, however integration tests can not run with out full change of #4372 .
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
#4372