New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: Add benchmark for rollback #4459
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
/run-integration-tests |
@breeswish Do you have any idea about the failing test? Although it's not related to this PR. |
The test itself was broken and has been fixed in pingcap/tidb-test#773. /run-integration-common-test |
@breeswish PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. How is the benchmark result?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fix the conflicts. |
@AndreMouche @breeswish PTAL again thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-tests |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What have you changed? (mandatory)
This PR adds benchmarks for MvccTxn::rollback.
It's divided two three different cases:
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
By CI
Does this PR affect documentation (docs) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No