raftstore: skip empty callback #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
BusyJay
added
sig/raft
kennytm
reviewed
May 10, 2019
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
|
@hicqu @overvenus PTAL |
overvenus
reviewed
May 14, 2019
|
|
||
| /// Test if the callback proposed by read index is cleared correctly. | ||
| #[test] | ||
| fn test_lease_read_callback_destroy() { |
There was a problem hiding this comment.
Does it fail without your change?
There was a problem hiding this comment.
Yes, it will panic at https://github.com/tikv/tikv/pull/4682/files#diff-79ba1b5dd0906a82a30f8ab9eba6ebd2R853.
overvenus
previously approved these changes
May 16, 2019
|
/run-integration-tests |
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
|
/run-integration-tests |
overvenus
approved these changes
May 27, 2019
hicqu
approved these changes
May 28, 2019
|
/run-integration-tests |
|
/run-integration-tests |
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Jun 13, 2019
* add test cases Signed-off-by: Jay Lee <busyjaylee@gmail.com> * skip empty callback Signed-off-by: Jay Lee <busyjaylee@gmail.com> * address comment Signed-off-by: Jay Lee <busyjaylee@gmail.com>
BusyJay
added a commit
to BusyJay/tikv
that referenced
this pull request
Jun 13, 2019
* add test cases Signed-off-by: Jay Lee <busyjaylee@gmail.com> * skip empty callback Signed-off-by: Jay Lee <busyjaylee@gmail.com> * address comment Signed-off-by: Jay Lee <busyjaylee@gmail.com>
BusyJay
added a commit
that referenced
this pull request
Jun 14, 2019
overvenus
pushed a commit
that referenced
this pull request
Jul 3, 2019
* raftstore: skip empty callback (#4682) * add test cases Signed-off-by: disksing <i@disksing.com> * fix format Signed-off-by: disksing <i@disksing.com> * fix build Signed-off-by: disksing <i@disksing.com> * Bump to 2.1.14 Signed-off-by: Neil Shen <overvenus@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* add test cases Signed-off-by: Jay Lee <busyjaylee@gmail.com> * skip empty callback Signed-off-by: Jay Lee <busyjaylee@gmail.com> * address comment Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
There are several situations in TiKV that propose with empty callbacks.
Such callbacks don't have to be sent to apply worker. Besides if an empty
callbacks is associated with an empty proposal, it may cause false report
of stale command.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit tests
Does this PR affect documentation (docs) or release note? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.