coprocessor: Support all data types for AVG() #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
changed the title
Signed-off-by: Breezewish <breezewish@pingcap.com>
|
/run-integration-tests |
sticnarf
reviewed
May 29, 2019
sticnarf
reviewed
May 29, 2019
sticnarf
reviewed
May 29, 2019
sticnarf
reviewed
May 29, 2019
sticnarf
reviewed
May 29, 2019
sticnarf
reviewed
May 29, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf
approved these changes
May 29, 2019
|
/run-integration-tests |
lonng
approved these changes
May 29, 2019
breezewish
added a commit
to breezewish/tikv
that referenced
this pull request
Jun 12, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
added a commit
to breezewish/tikv
that referenced
this pull request
Jun 12, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
added a commit
to breezewish/tikv
that referenced
this pull request
Jun 12, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Breezewish breezewish@pingcap.com
What have you changed? (mandatory)
This PR adds supports of using all data types in AVG(), by half-implementing CAST functions necessary for these data types.
Note: These implementations are not fully TiDB compatible. It is only ensured that the behaviour is not worse than existing cast behaviour in non-batch aggregation functions.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
New unit tests.