Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: clear stale reads after role change #4810

Merged
merged 4 commits into from May 31, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented May 30, 2019

Signed-off-by: qupeng qupeng@pingcap.com

Clear stale reads after role change, even if the role change is in one Ready with some read states.

What are the type of the changes? (mandatory)

Bug fix.

How has this PR been tested? (mandatory)

make dev.

Close #4814

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu requested review from nolouch and overvenus May 30, 2019 10:40
@hicqu
Copy link
Contributor Author

hicqu commented May 30, 2019

/run-all-tests

nolouch
nolouch previously approved these changes May 30, 2019
@hicqu hicqu added the type/bugfix Type: PR - Fix a bug label May 30, 2019
@siddontang
Copy link
Contributor

@hicqu

which issue do you fix?

@hicqu hicqu closed this May 31, 2019
@hicqu hicqu reopened this May 31, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu hicqu merged commit 5865486 into tikv:master May 31, 2019
@hicqu hicqu deleted the stale-leader-read-index branch May 31, 2019 06:17
hicqu added a commit to hicqu/tikv that referenced this pull request Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to hicqu/tikv that referenced this pull request Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
zhangjinpeng87 pushed a commit that referenced this pull request Jun 20, 2019
* raftstore: clear stale reads after role change (#4810)

Signed-off-by: qupeng <qupeng@pingcap.com>

* improve bad-regions and tombstone subcommands for tikv-ctl (#4862)

Signed-off-by: qupeng <qupeng@pingcap.com>

* add 2 metrics. (#4830)

Signed-off-by: qupeng <qupeng@pingcap.com>

* Add missing fsync calls in the snapshot module (#4850)

Signed-off-by: qupeng <qupeng@pingcap.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bugfix Type: PR - Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands could be pending in scheduler forever
4 participants