New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftstore: clear stale reads after role change #4810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
/run-all-tests |
nolouch
previously approved these changes
May 30, 2019
which issue do you fix? |
Signed-off-by: qupeng <qupeng@pingcap.com>
overvenus
approved these changes
May 31, 2019
nolouch
approved these changes
May 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hicqu
added a commit
to hicqu/tikv
that referenced
this pull request
Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
added a commit
to hicqu/tikv
that referenced
this pull request
Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
zhangjinpeng87
pushed a commit
that referenced
this pull request
Jun 20, 2019
* raftstore: clear stale reads after role change (#4810) Signed-off-by: qupeng <qupeng@pingcap.com> * improve bad-regions and tombstone subcommands for tikv-ctl (#4862) Signed-off-by: qupeng <qupeng@pingcap.com> * add 2 metrics. (#4830) Signed-off-by: qupeng <qupeng@pingcap.com> * Add missing fsync calls in the snapshot module (#4850) Signed-off-by: qupeng <qupeng@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qupeng qupeng@pingcap.com
Clear stale reads after role change, even if the
role change
is in oneReady
with someread state
s.What are the type of the changes? (mandatory)
Bug fix.
How has this PR been tested? (mandatory)
make dev.
Close #4814