Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: clear stale reads after role change #4810

Merged
merged 4 commits into from May 31, 2019

Conversation

@hicqu
Copy link
Contributor

hicqu commented May 30, 2019

Signed-off-by: qupeng qupeng@pingcap.com

Clear stale reads after role change, even if the role change is in one Ready with some read states.

What are the type of the changes? (mandatory)

Bug fix.

How has this PR been tested? (mandatory)

make dev.

Close #4814

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu requested review from nolouch and overvenus May 30, 2019
@hicqu

This comment has been minimized.

Copy link
Contributor Author

hicqu commented May 30, 2019

/run-all-tests

@hicqu hicqu added the T: BugFix label May 30, 2019
@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented May 30, 2019

@hicqu

which issue do you fix?

@hicqu hicqu closed this May 31, 2019
@hicqu hicqu reopened this May 31, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
cargo fmt
Signed-off-by: qupeng <qupeng@pingcap.com>
Copy link
Contributor

nolouch left a comment

LGTM

@hicqu hicqu merged commit 5865486 into tikv:master May 31, 2019
2 checks passed
2 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@hicqu hicqu deleted the hicqu:stale-leader-read-index branch May 31, 2019
hicqu added a commit to hicqu/tikv that referenced this pull request Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to hicqu/tikv that referenced this pull request Jun 19, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
zhangjinpeng1987 added a commit that referenced this pull request Jun 20, 2019
* raftstore: clear stale reads after role change (#4810)

Signed-off-by: qupeng <qupeng@pingcap.com>

* improve bad-regions and tombstone subcommands for tikv-ctl (#4862)

Signed-off-by: qupeng <qupeng@pingcap.com>

* add 2 metrics. (#4830)

Signed-off-by: qupeng <qupeng@pingcap.com>

* Add missing fsync calls in the snapshot module (#4850)

Signed-off-by: qupeng <qupeng@pingcap.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.