Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a tiny bug about tikv-ctl #4910

Merged
merged 5 commits into from Jun 20, 2019
Merged

fix a tiny bug about tikv-ctl #4910

merged 5 commits into from Jun 20, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jun 17, 2019

Signed-off-by: qupeng qupeng@pingcap.com

What have you changed? (mandatory)

Fix a bug about tikv-ctl. For dump-mvcc command, it needs to print an error log instead of print mvcc infos about the next key.

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu added the component/tikv-ctl Component: TiKV Control label Jun 17, 2019
@hicqu hicqu added the type/bugfix Type: PR - Fix a bug label Jun 17, 2019
@siddontang
Copy link
Contributor

where is the corresponding issue?

@hicqu
Copy link
Contributor Author

hicqu commented Jun 20, 2019

@siddontang there is no issue about this. I guess for simple PRs we don't need a issue. We can discribe the problem in the PR directly.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu hicqu merged commit c69229e into tikv:master Jun 20, 2019
@hicqu hicqu deleted the ctl-mvcc-fix branch June 20, 2019 03:54
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv-ctl Component: TiKV Control type/bugfix Type: PR - Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants