Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-rocksdb and change branch #4937

Merged
merged 4 commits into from Jun 20, 2019

Conversation

yiwu-arbug
Copy link
Contributor

What have you changed? (mandatory)

Update rocksdb to with the fix:

b4f33387f 2019-06-20 yiwu@pingcap.com     Fix ingested file and direcotry not being sync (#96)

Also point change rust-rocksdb to point to tikv-3.0 branch.

What are the type of the changes? (mandatory)

Bug fix & Engineering

How has this PR been tested? (mandatory)

CI

Does this PR affect documentation (docs) or release note? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

Signed-off-by: Yi Wu <yiwu@pingcap.com>
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996 Connor1996 added the type/cherry-pick Type: PR - Cherry pick label Jun 20, 2019
Signed-off-by: Yi Wu <yiwu@pingcap.com>
@@ -3,6 +3,8 @@ All notable changes to this project are documented in this file.
See also [TiDB Changelog](https://github.com/pingcap/tidb/blob/master/CHANGELOG.md) and [PD Changelog](https://github.com/pingcap/pd/blob/master/CHANGELOG.md).

## [Unreleased]
+ Engine
- Synchronize all files and directories for received snapshots [#4853](https://github.com/tikv/tikv/pull/4853)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy paste from 2.1.12 changelog.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change PR link

@Connor1996 Connor1996 added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Jun 20, 2019
@Connor1996
Copy link
Member

/run-all-tests

@Connor1996
Copy link
Member

/run-all-tests

@Connor1996 Connor1996 merged commit b2e216a into tikv:release-3.0 Jun 20, 2019
@yiwu-arbug yiwu-arbug deleted the sync_ingest_tikv3.0 branch June 20, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants