New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust-rocksdb and change branch #4937
Conversation
Signed-off-by: Yi Wu <yiwu@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yi Wu <yiwu@pingcap.com>
b38a308
to
2e61bdc
Compare
@@ -3,6 +3,8 @@ All notable changes to this project are documented in this file. | |||
See also [TiDB Changelog](https://github.com/pingcap/tidb/blob/master/CHANGELOG.md) and [PD Changelog](https://github.com/pingcap/pd/blob/master/CHANGELOG.md). | |||
|
|||
## [Unreleased] | |||
+ Engine | |||
- Synchronize all files and directories for received snapshots [#4853](https://github.com/tikv/tikv/pull/4853) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copy paste from 2.1.12 changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change PR link
/run-all-tests |
/run-all-tests |
What have you changed? (mandatory)
Update rocksdb to with the fix:
Also point change rust-rocksdb to point to tikv-3.0 branch.
What are the type of the changes? (mandatory)
Bug fix & Engineering
How has this PR been tested? (mandatory)
CI
Does this PR affect documentation (docs) or release note? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)