*: remove tikv-importer #5036
Merged
*: remove tikv-importer #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
force-pushed
the
remove-importer-binary
branch
2 times, most recently
from
54ca51d
to
5f439af
Compare
The KV importer service has been extracted into the tikv/importer repository. Only the SST importer service needs to remain here. All code related to the KV importer has been removed here. Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
remove-importer-binary
branch
from
5f439af
to
ef559e4
Compare
|
/run-integration-tests |
|
If we can support a plugin which can let the user register their own gRPC server, maybe we can make code cleaner, right? @kennytm |
|
@siddontang Certainly. But that may make using Importer harder, since that ImportSSTService plugin will need to be installed on every TiKV node. |
|
Could you move |
|
@overvenus OK, will move in another PR. |
|
/run-integration-tests |
I guess it is spurious. /test |
|
/run-integration-common-test |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
The KV importer service has been extracted into the tikv/importer repository. Only the SST importer service needs to remain here. All code related to the KV importer has been removed here. Signed-off-by: kennytm <kennytm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kennytm kennytm@gmail.com
What have you changed? (mandatory)
The KV importer service has been extracted into the tikv/importer repository. Only the SST importer service needs to remain here. All code related to the KV importer has been removed here.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
cargo check
Does this PR affect documentation (docs) or release note? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
No, the binary has already been switched to be packaged from tikv/importer.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)