Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove tikv-importer #5036

Merged
merged 3 commits into from Jul 8, 2019

Conversation

@kennytm
Copy link
Contributor

commented Jul 5, 2019

Signed-off-by: kennytm kennytm@gmail.com

What have you changed? (mandatory)

The KV importer service has been extracted into the tikv/importer repository. Only the SST importer service needs to remain here. All code related to the KV importer has been removed here.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

cargo check

Does this PR affect documentation (docs) or release note? (mandatory)

  • May need to be included in the release note for the source code location.

Does this PR affect tidb-ansible update? (mandatory)

No, the binary has already been switched to be packaged from tikv/importer.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@kennytm kennytm added the C: Build label Jul 5, 2019

@kennytm kennytm force-pushed the kennytm:remove-importer-binary branch 2 times, most recently from 54ca51d to 5f439af Jul 5, 2019

*: remove tikv-importer
The KV importer service has been extracted into the tikv/importer
repository. Only the SST importer service needs to remain here. All code
related to the KV importer has been removed here.

Signed-off-by: kennytm <kennytm@gmail.com>

@kennytm kennytm force-pushed the kennytm:remove-importer-binary branch from 5f439af to ef559e4 Jul 5, 2019

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

/run-integration-tests

@siddontang

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

If we can support a plugin which can let the user register their own gRPC server, maybe we can make code cleaner, right? @kennytm

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

@siddontang Certainly. But that may make using Importer harder, since that ImportSSTService plugin will need to be installed on every TiKV node.

@overvenus
Copy link
Contributor

left a comment

LGTM

@siddontang
Copy link
Contributor

left a comment

LGTM

@overvenus

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Could you move src/import to components/import?

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@overvenus OK, will move in another PR.

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

/run-integration-tests

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tikv_ghpr_test/detail/tikv_ghpr_test/6452/pipeline/

thread 'raftstore-1-1::test_node_request_snapshot_reject_merge' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:999:5

I guess it is spurious.

/test

@kennytm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

/run-integration-common-test

@kennytm kennytm merged commit 09de060 into tikv:master Jul 8, 2019

5 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@kennytm kennytm deleted the kennytm:remove-importer-binary branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.