Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore/store: remove unnecessary clone #5039

Merged
merged 3 commits into from Jul 8, 2019
Merged

raftstore/store: remove unnecessary clone #5039

merged 3 commits into from Jul 8, 2019

Conversation

lonng
Copy link
Member

@lonng lonng commented Jul 6, 2019

Signed-off-by: Lonng heng@lonng.org

What have you changed? (mandatory)

Remove unnecessary clone.

What are the type of the changes? (mandatory)

The currently defined types are listed below, please pick one of the types for this

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Existing unit tests.

Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng added the type/enhancement Type: Issue - Enhancement label Jul 6, 2019
@lonng
Copy link
Member Author

lonng commented Jul 6, 2019

/run-all-tests

@BusyJay
Copy link
Member

BusyJay commented Jul 6, 2019

@overvenus PTAL

@lonng
Copy link
Member Author

lonng commented Jul 6, 2019

@BusyJay The state cannot be shared with others in Rust. So I think it's safe to remove this clone.

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng merged commit 9892dd4 into tikv:master Jul 8, 2019
@lonng lonng deleted the avoid-unnecessary-clone branch July 8, 2019 02:12
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Lonng <heng@lonng.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants