Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cop: Cherry pick several PRs to release-3.0 #5048

Merged
merged 6 commits into from Jul 12, 2019

Conversation

breezewish
Copy link
Member

What have you changed? (mandatory)

#5007: Support variable number of arguments
#4982: RPN function ABS()
#5016: RPN function IN()
#5020: RPN function CASE_WHEN()
#5033: Validator for RPN functions

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Existing tests.

breezewish and others added 5 commits July 9, 2019 11:05
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: MWish <1506118561@qq.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
* Support CASE_WHEN

Signed-off-by: Breezewish <breezewish@pingcap.com>

* Add some helps for varg and raw_varg

Signed-off-by: Breezewish <breezewish@pingcap.com>

* Fix bug according to comments

Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breezewish
Copy link
Member Author

/run-integration-tests

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish
Copy link
Member Author

/run-integration-tests

@breezewish breezewish merged commit 89ad909 into tikv:release-3.0 Jul 12, 2019
@breezewish breezewish deleted the release-3.0-cop2 branch July 12, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants