pessimistic-txn: eliminate CleanUpWaitFor when waiter timeouts
#5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
|
LGTM |
MyonKeminta
reviewed
Jul 31, 2019
| @@ -322,6 +322,7 @@ fn run_raft_server(pd_client: RpcClient, cfg: &TiKvConfig, security_mgr: Arc<Sec | |||
| pd_client, | |||
| resolver, | |||
| cfg.pessimistic_txn.monitor_membership_interval, | |||
| cfg.pessimistic_txn.wait_for_lock_timeout, | |||
There was a problem hiding this comment.
I'm afraid there might be too many arguments. May it be better if we pass the whole cfg.pessimistic_txn?
There was a problem hiding this comment.
Yes. I will file a PR to pass &cfg.pessimistic_txn to WaiterManger and Detector.
AndreMouche
approved these changes
Jul 31, 2019
| ) -> Self { | ||
| Self { | ||
| store_id, | ||
| leader_info: None, | ||
| leader_client: None, | ||
| // TODO: make it configurable. | ||
| detect_table: Rc::new(RefCell::new(DetectTable::new(time::Duration::from_secs(3)))), | ||
| detect_table: Rc::new(RefCell::new(DetectTable::new(time::Duration::from_millis( |
There was a problem hiding this comment.
I think we can remove the Rc in another PR.
youjiali1995
added a commit
to youjiali1995/tikv
that referenced
this pull request
Aug 5, 2019
…v#5157) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
…v#5157) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What have you changed? (mandatory)
Use
wait-for-lock-timeoutas the TTL of the detect table. So when waiter timeouts, there is no need to send 'CleanUpWaitFor` request to the deadlock detector.What are the type of the changes? (mandatory)