Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copr: implement RealDivide for RPN function framework #5182

Merged
merged 8 commits into from Aug 6, 2019
Merged

Copr: implement RealDivide for RPN function framework #5182

merged 8 commits into from Aug 6, 2019

Conversation

iosmanthus
Copy link
Member

What have you changed? (mandatory)

Add RealDivide to RPN function framework.

What are the type of changes? (mandatory)

  • New feature (a change which adds functionality)

How has this PR been tested? (mandatory)

cargo test impl_arithmetic in componets/tidb_query

@AndreMouche AndreMouche added the sig/coprocessor SIG: Coprocessor label Aug 5, 2019
breezewish and others added 4 commits August 5, 2019 15:05
@breezewish
Allow RPN evaluate util evaluating into scalar value
77468f0 
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breezewish
Extract divide_by_zero cases
c75533a 
Signed-off-by: Breezewish <breezewish@pingcap.com>
@iosmanthus
Merge branch 'master' of https://github.com/tikv/tikv into real-divide
9c4f0e2
@iosmanthus
Add ReadDivide to RPN framework
d4d80ab 
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
breezewish
breezewish previously approved these changes Aug 5, 2019
View reviewed changes
@breezewish
Copy link
Member

/run-all-tests

@iosmanthus iosmanthus requested a review from lonng August 5, 2019 10:10
@breezewish
Copy link
Member

/test

sticnarf
sticnarf approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sticnarf sticnarf added the status/can-merge Status: Can merge to base branch label Aug 6, 2019
@iosmanthus iosmanthus merged commit 1500ea5 into tikv:master Aug 6, 2019
@iosmanthus iosmanthus deleted the real-divide branch August 6, 2019 07:10
YangKeao added a commit to YangKeao/tikv that referenced this pull request Sep 5, 2019
@YangKeao
Revert "Copr: implement RealDivide for RPN function framework (ti…
c92b37a 
…kv#5182)"

This reverts commit 1500ea5.
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
@iosmanthus
Copr: implement RealDivide for RPN function framework (tikv#5182)
9af1f52 
* Allow RPN evaluate util evaluating into scalar value

Signed-off-by: Breezewish <breezewish@pingcap.com>

* Extract divide_by_zero cases

Signed-off-by: Breezewish <breezewish@pingcap.com>

* Add `ReadDivide` to `RPN` framework

Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

* add `DivideReal` mapping to map_pb_sig_to_rpn_func

Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@sticnarf sticnarf sticnarf approved these changes

@mapleFU mapleFU Awaiting requested review from mapleFU

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
sig/coprocessor SIG: Coprocessor status/can-merge Status: Can merge to base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iosmanthus @breezewish @sticnarf @AndreMouche