Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copr: implement `RealDivide` for `RPN` function framework #5182

Merged
merged 8 commits into from Aug 6, 2019

Conversation

@iosmanthus
Copy link
Contributor

commented Aug 2, 2019

What have you changed? (mandatory)

Add RealDivide to RPN function framework.

What are the type of changes? (mandatory)

  • New feature (a change which adds functionality)

How has this PR been tested? (mandatory)

cargo test impl_arithmetic in componets/tidb_query

@iosmanthus iosmanthus requested review from sticnarf, breeswish and mapleFU Aug 2, 2019

@AndreMouche AndreMouche added the C: Copr label Aug 5, 2019

@iosmanthus iosmanthus requested a review from breeswish Aug 5, 2019

breeswish and others added some commits Aug 5, 2019

Allow RPN evaluate util evaluating into scalar value
Signed-off-by: Breezewish <breezewish@pingcap.com>
Extract divide_by_zero cases
Signed-off-by: Breezewish <breezewish@pingcap.com>
Add `ReadDivide` to `RPN` framework
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

@iosmanthus iosmanthus force-pushed the iosmanthus:real-divide branch from fe2075a to d4d80ab Aug 5, 2019

@iosmanthus iosmanthus requested a review from breeswish Aug 5, 2019

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/run-all-tests

@iosmanthus iosmanthus requested a review from lonng Aug 5, 2019

@breeswish

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/test

iosmanthus added some commits Aug 5, 2019

add `DivideReal` mapping to map_pb_sig_to_rpn_func
Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>
@sticnarf
Copy link
Contributor

left a comment

LGTM

@sticnarf sticnarf added the S: CanMerge label Aug 6, 2019

@iosmanthus iosmanthus merged commit 1500ea5 into tikv:master Aug 6, 2019

3 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@iosmanthus iosmanthus deleted the iosmanthus:real-divide branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.