*: deny unknown fields when deserializing config TOML #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added
component/server
|
/run-integration-tests |
|
Does this PR need to be cherry picked to 3.0? |
|
@breeswish We could. WDYT |
|
@BusyJay @overvenus Do you have some ideas? |
overvenus
reviewed
Aug 5, 2019
| @@ -75,6 +75,7 @@ fn memory_mb_for_cf(is_raft_db: bool, cf: &str) -> usize { | |||
|
|
|||
| #[derive(Clone, Serialize, Deserialize, PartialEq, Debug)] | |||
| #[serde(default)] | |||
| #[serde(deny_unknown_fields)] | |||
There was a problem hiding this comment.
Seems we can no longer downgrade if there is a new config exist?
There was a problem hiding this comment.
You'd need to comment out that config manually. The error message will tell you the name of the offending field.
There was a problem hiding this comment.
seem TiDB has the same problem now. is it ok?
@shenli
overvenus
approved these changes
Aug 9, 2019
|
/run-all-tests |
|
Need cherry pick? @siddontang @BusyJay |
This was referenced Aug 21, 2019
YangKeao
pushed a commit
to YangKeao/tikv
that referenced
this pull request
Aug 26, 2019
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Aug 28, 2019
)" This reverts commit 0343796.
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Aug 28, 2019
)" This reverts commit 0343796. Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Aug 28, 2019
)" This reverts commit 0343796. Signed-off-by: kennytm <kennytm@gmail.com>
sre-bot
pushed a commit
that referenced
this pull request
Aug 28, 2019
#5350) Signed-off-by: kennytm <kennytm@gmail.com>
YangKeao
added a commit
to YangKeao/tikv
that referenced
this pull request
Sep 5, 2019
…tikv#5190)" (tikv#5350)" This reverts commit 83a2357.
YangKeao
added a commit
to YangKeao/tikv
that referenced
this pull request
Sep 5, 2019
)" This reverts commit 0343796.
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: kennytm <kennytm@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
)" (tikv#5350) Signed-off-by: kennytm <kennytm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Add
#[serde(deny_unknown_fields)]to all config structures, which will cause deserialization to fail if the source contains an unrecognized field. The rationale to catch typo or misplaced settings.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
cargo test --test integrations -- test_error_on_unrecognized_configDoes this PR affect documentation (docs) or release note? (mandatory)
Release note.
Does this PR affect tidb-ansible update? (mandatory)
Hopefully no 🙃.
Refer to a related PR or issue link (optional)
pingcap/tidb#9855
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)