Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve backup checksum feature #5683

Merged
merged 15 commits into from Oct 23, 2019
Merged

improve backup checksum feature #5683

merged 15 commits into from Oct 23, 2019

Conversation

NingLin-P
Copy link
Member

Signed-off-by: linning linningde25@gmail.com

What have you changed?

improve backup checksum feature

What is the type of the changes?

  • Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Please select the tests that you ran to verify your changes:

  • Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

@NingLin-P
improve backup checksum feature
62d8040 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P added the component/backup-restore Component: backup, import, external_storage label Oct 18, 2019
@NingLin-P NingLin-P changed the title improve backup checksum feature [WIP] improve backup checksum feature Oct 18, 2019
@NingLin-P
Copy link
Member Author

/run-all-tests

@MyonKeminta MyonKeminta mentioned this pull request Oct 21, 2019
Merged
2 tasks
@NingLin-P
add backup_meta test
768db55 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P force-pushed the backup/checksum-with-crc64xor branch from 21a7636 to 768db55 Compare October 22, 2019 03:09
@NingLin-P
Copy link
Member Author

/run-all-tests

@NingLin-P
update tipb
86519d0 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
add undo rewrite checksum
6a97951 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P changed the title [WIP] improve backup checksum feature improve backup checksum feature Oct 22, 2019
@NingLin-P
Copy link
Member Author

PTAL @overvenus @kennytm @3pointer

kennytm
kennytm reviewed Oct 22, 2019
View reviewed changes
components/backup/src/writer.rs Outdated Show resolved Hide resolved
components/backup/src/writer.rs Outdated Show resolved Hide resolved
components/backup/src/writer.rs Outdated Show resolved Hide resolved
components/backup/src/writer.rs Outdated Show resolved Hide resolved
src/coprocessor/checksum.rs Outdated Show resolved Hide resolved
src/coprocessor/checksum.rs Outdated Show resolved Hide resolved
overvenus
overvenus reviewed Oct 23, 2019
View reviewed changes
components/backup/src/writer.rs Outdated Show resolved Hide resolved
components/backup/tests/integrations/test_backup.rs Show resolved Hide resolved
components/tikv_util/src/file.rs Outdated Show resolved Hide resolved
@NingLin-P
refactor
c6e1ad5 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P force-pushed the backup/checksum-with-crc64xor branch from 1286c5b to c6e1ad5 Compare October 23, 2019 05:15
@NingLin-P
Copy link
Member Author

encounter unstable test #3831

@NingLin-P
Copy link
Member Author

/run-all-tests

overvenus
overvenus reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

components/backup/src/writer.rs Outdated Show resolved Hide resolved
@NingLin-P
remove unwrap
1249f1e 
Signed-off-by: linning <linningde25@gmail.com>
kennytm
kennytm reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

components/backup/src/writer.rs Outdated Show resolved Hide resolved
components/backup/tests/integrations/test_backup.rs Outdated Show resolved Hide resolved
src/coprocessor/checksum.rs Outdated Show resolved Hide resolved
overvenus
overvenus reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus added the needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 label Oct 23, 2019
@kennytm kennytm added status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals labels Oct 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit f4666a6 into tikv:master Oct 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

cherry pick to release-3.1 failed

sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
@NingLin-P @sre-bot
improve backup checksum feature (tikv#5683)
ddba189 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@overvenus overvenus overvenus approved these changes

@5kbpers 5kbpers Awaiting requested review from 5kbpers

Assignees
No one assigned
Labels
component/backup-restore Component: backup, import, external_storage needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NingLin-P @sre-bot @kennytm @overvenus