Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: Add vectorize rand and rand_with_seed #6117

Merged
merged 41 commits into from
Dec 10, 2019
Merged

copr: Add vectorize rand and rand_with_seed #6117

merged 41 commits into from
Dec 10, 2019

Conversation

hi-rustin
Copy link
Member

Signed-off-by: Rustin-Liu rustin.liu@gmail.com
PCP #5751

What have you changed?

Add vectorize rand.

What is the type of the changes?

  • New feature (a change which adds functionality)

How is the PR tested?

  • Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

None

Does this PR affect tidb-ansible?

None

Refer to a related PR or issue link (optional)

#5751

Benchmark result if necessary (optional)

None

Any examples? (optional)

None

@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution Type: PR - From contributors label Nov 30, 2019
@hi-rustin
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2019

/ /run-all-tests

@andylokandy
Copy link
Contributor

The last thing is to make a PR in https://github.com/tikv/copr-test and trigger the integration-copr-test here

components/tidb_query/src/rpn_expr/impl_math.rs Outdated Show resolved Hide resolved
components/tidb_query/src/util.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you created the copr-test pr?

@hi-rustin
Copy link
Member Author

@sre-bot /run-integration-copr-test copr-test=pr/99

@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2019

/ /run-integration-copr-test copr-test=pr/99

@hi-rustin
Copy link
Member Author

Have you created the copr-test pr?

Thank you, passed.

@andylokandy
Copy link
Contributor

/run-integration-copr-test copr-test=pr/99

@andylokandy andylokandy added the status/LGT1 Status: PR - There is already 1 approval label Dec 1, 2019
andylokandy
andylokandy previously approved these changes Dec 1, 2019
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylokandy
Copy link
Contributor

/run-integration-copr-test copr-test=pr/99

andylokandy
andylokandy previously approved these changes Dec 1, 2019
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@hi-rustin
Copy link
Member Author

PTAL~

@andylokandy
Copy link
Contributor

/test

andylokandy
andylokandy previously approved these changes Dec 9, 2019
@andylokandy
Copy link
Contributor

@breeswish PTAL

@andylokandy
Copy link
Contributor

/award-point 200

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

Update score success, the task will rewarded 200 after merged.

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@hi-rustin
Copy link
Member Author

PTAL~

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylokandy
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 134c566 into tikv:master Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

@Rustin-Liu complete task #5751 and get 200 score, currerent score 250.

zhang555 pushed a commit to zhang555/tikv that referenced this pull request Dec 16, 2019
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Dian Luo <andylokandy@hotmail.com>
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Dian Luo <andylokandy@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Type: PR - From contributors sig/coprocessor SIG: Coprocessor status/can-merge Status: Can merge to base branch status/LGT1 Status: PR - There is already 1 approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants