backup: hash backup file name #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
reviewed
Dec 6, 2019
components/backup/src/endpoint.rs
Outdated
Comment on lines
574
to
579
| "{}_{}_{}_{:?}", | ||
| store_id, | ||
| region.get_id(), | ||
| region.get_region_epoch().get_version(), |
There was a problem hiding this comment.
Should use "{}", hex::encode(k).
Here is an example of {:?}, vec![1, 2, 3] => [1, 2, 3]
There was a problem hiding this comment.
hex::encode is used in sha256, I think use String::from_utf8 is enough
components/backup/src/endpoint.rs
Outdated
| @@ -382,7 +382,7 @@ impl<E: Engine, R: RegionInfoProvider> Endpoint<E, R> { | |||
| let key = brange | |||
| .start_key | |||
| .clone() | |||
| .map(|k| hex::encode(k.into_raw().unwrap())); | |||
| .and_then(|k| tikv_util::file::sha256(&k.into_raw().unwrap()).ok()); | |||
There was a problem hiding this comment.
Could you add some comments about why we need it?
overvenus
added
component/backup-restore
3pointer
force-pushed
the
fix_backup_filename
branch
3 times, most recently
from
4906ac6
to
6250fc5
Compare
Signed-off-by: luancheng <luancheng@pingcap.com>
3pointer
force-pushed
the
fix_backup_filename
branch
from
6250fc5
to
4601b61
Compare
3pointer
changed the title
Signed-off-by: luancheng <luancheng@pingcap.com>
3pointer
force-pushed
the
fix_backup_filename
branch
from
e512fc3
to
7ac5ef6
Compare
3pointer
changed the title
|
/run-unit-test |
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
3pointer
added a commit
to 3pointer/tikv
that referenced
this pull request
Dec 9, 2019
Signed-off-by: luancheng <luancheng@pingcap.com>
3pointer
added a commit
to 3pointer/tikv
that referenced
this pull request
Dec 10, 2019
Signed-off-by: luancheng <luancheng@pingcap.com>
overvenus
pushed a commit
that referenced
this pull request
Dec 10, 2019
zhang555
pushed a commit
to zhang555/tikv
that referenced
this pull request
Dec 16, 2019
Signed-off-by: luancheng <luancheng@pingcap.com>
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: luancheng <luancheng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: luancheng luancheng@pingcap.com
What have you changed?
use start key sha256 to replace raw start key, if we use start key as file name we could meet
"file name too long" error because some index key are longer than 255 bytes
What is the type of the changes?
How is the PR tested?
Please select the tests that you ran to verify your changes:
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
N/A
Does this PR affect
tidb-ansible?N/A
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)